Include s3/website test only when k2v is enabled #556

Closed

jirutka wants to merge 1 commit from jirutka/garage:fix-website-test-k2v into main

jirutka commented

2023-04-29 23:05:29 +00:00

Contributor

It depends on k2v feature, so fails to build when k2v is disabled.

jirutka added 1 commit 2023-04-29 23:05:30 +00:00

Include s3/website test only when k2v is enabled

continuous-integration/drone/pr Build is passing

Details

6468535a96

It depends on k2v feature, so fails to build when k2v is disabled.

trinity-1686a commented

2023-04-30 00:51:21 +00:00

Owner

I don't think any of these tests depends on k2v. What error are you getting?

👍 1

jirutka commented

2023-05-06 22:56:26 +00:00

Author

Contributor

1ecd88c01f/src/garage/tests/s3/website.rs:

use crate::k2v::json_body;

https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/1ecd88c01f0857139921214a264128e5639e31db/src/garage/tests/s3/website.rs: ```rs use crate::k2v::json_body; ```

trinity-1686a commented

2023-05-07 08:17:09 +00:00

Owner

hum, that function isn't specific to k2v, it's currently in :/garage/src/garage/tests/k2v/mod.rs, but its place should probably be :/garage/src/garage/tests/lib.rs instead. That would fix your issue, and not disable some tests when they could be enabled

hum, that function isn't specific to k2v, it's currently in `:/garage/src/garage/tests/k2v/mod.rs`, but its place should probably be `:/garage/src/garage/tests/lib.rs` instead. That would fix your issue, and not disable some tests when they could be enabled

jirutka commented

2023-05-07 15:48:37 +00:00

Author

Contributor

BTW, the error message is this:

$ cargo test --no-default-features --features system-libs,sled
...
   Compiling garage v0.8.2
error[E0432]: unresolved import `crate::k2v`
 --> src/garage/tests/s3/website.rs:3:12
  |
3 | use crate::k2v::json_body;
  |            ^^^ could not find `k2v` in the crate root

BTW, the error message is this: ``` $ cargo test --no-default-features --features system-libs,sled ... Compiling garage v0.8.2 error[E0432]: unresolved import `crate::k2v` --> src/garage/tests/s3/website.rs:3:12 | 3 | use crate::k2v::json_body; | ^^^ could not find `k2v` in the crate root ```