Include s3/website test only when k2v is enabled #556
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#556
Loading…
Reference in New Issue
No description provided.
Delete Branch "jirutka/garage:fix-website-test-k2v"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It depends on k2v feature, so fails to build when k2v is disabled.
I don't think any of these tests depends on k2v. What error are you getting?
1ecd88c01f/src/garage/tests/s3/website.rs
:hum, that function isn't specific to k2v, it's currently in
:/garage/src/garage/tests/k2v/mod.rs
, but its place should probably be:/garage/src/garage/tests/lib.rs
instead. That would fix your issue, and not disable some tests when they could be enabledBTW, the error message is this:
See the comment of @trinity-1686a : the
json_body
function needs to be moved, not the entire module disabled.Fixed in #619
Pull request closed