Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

k2v-client: Add support for native TLS library #560

Closed
jirutka wants to merge 2 commits from jirutka/garage:k2v-native-tls into main
pull from: jirutka/garage:k2v-native-tls
merge into: Deuxfleurs:main
Conversation 2 Commits 2 Files Changed 5 +121 -10
jirutka commented 2023-05-07 13:40:12 +00:00
Contributor
Copy Link

So it can be dynamically linked with the system-provided TLS library instead
of bundling rustls.

So it can be dynamically linked with the system-provided TLS library instead of bundling rustls.
jirutka force-pushed k2v-native-tls from f8019cc4ea to cacb5eb7eb 2023-05-07 13:41:33 +00:00 Compare
jirutka force-pushed k2v-native-tls from cacb5eb7eb to b8342dfaaf 2023-05-07 13:42:07 +00:00 Compare
jirutka force-pushed k2v-native-tls from b8342dfaaf to 92a86e3cd1 2023-05-07 13:49:40 +00:00 Compare
jirutka added 1 commit 2023-05-07 15:53:48 +00:00
lx commented 2023-05-09 09:46:29 +00:00
Owner
Copy Link

Can you give me write access to this branch so that I can push an updated Cargo.nix file?

We can try building this, but I'm pretty sure it will break our CI pipeline. We had a lot of trouble trying to make static builds for all 4 supported architectures and removing openssl entierly was a necessary step to make it work.

Also, if this change is only for k2v-client, why did you also change the dev-dependencies in src/garage/Cargo.toml ? Maybe without that change we have a chance of building this on our CI, as k2v-client is not built by it.

Can you give me write access to this branch so that I can push an updated `Cargo.nix` file? We can try building this, but I'm pretty sure it will break our CI pipeline. We had a lot of trouble trying to make static builds for all 4 supported architectures and removing openssl entierly was a necessary step to make it work. Also, if this change is only for k2v-client, why did you also change the dev-dependencies in `src/garage/Cargo.toml` ? Maybe without that change we have a chance of building this on our CI, as k2v-client is not built by it.
lx commented 2023-08-28 09:29:43 +00:00
Owner
Copy Link

Closing for inactivity.

Closing for inactivity.
lx closed this pull request 2023-08-28 09:29:43 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#560
No description provided.
Delete Branch "jirutka/garage:k2v-native-tls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?