Deuxfleurs/garage
42
39
Fork 55
Code Issues 71 Pull requests 7 Releases 29 Wiki Activity

Run clippy on the whole project #58

Closed
trinity-1686a wants to merge 9 commits from trinity-1686a:clippy into main
pull from: trinity-1686a:clippy
merge into: Deuxfleurs:main
Conversation 1 Commits 9 Files changed 45 +534 -515
trinity-1686a commented 2021-04-23 20:59:54 +00:00
Owner
Copy link

Clippy is a linter widelly used. This PR aims at making it not warn on Garage code, and add it as part of CI

Clippy is a linter widelly used. This PR aims at making it not warn on Garage code, and add it as part of CI
👍 1
trinity-1686a reviewed 2021-04-23 21:01:59 +00:00
src/rpc/membership.rs Outdated
@ -424,7 +424,6 @@ impl System {
warn!("Node {:?} seems to be down.", id);
if !ring.config.members.contains_key(id) {
info!("Removing node {:?} from status (not in config and not responding to pings anymore)", id);
drop(st);
trinity-1686a commented 2021-04-23 21:01:59 +00:00
Author
Owner
Copy link

this line was triggering this lint, I'm not sure what the code was supposed to do, but it probably wasn't doing what expected

this line was triggering [this lint](https://rust-lang.github.io/rust-clippy/stable/index.html#drop_ref), I'm not sure what the code was supposed to do, but it probably wasn't doing what expected
trinity-1686a force-pushed clippy from 79587cf970 to 0df7846933 2021-05-02 19:35:46 +00:00 Compare
trinity-1686a force-pushed clippy from 0df7846933 to af854ecb15 2021-05-02 19:43:15 +00:00 Compare
trinity-1686a added 1 commit 2021-05-02 20:26:39 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7cfea920c8 add signature
trinity-1686a added 1 commit 2021-05-02 21:13:17 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ce8bf7b900 rename types to CamelCase
lx commented 2021-05-03 20:18:44 +00:00
Owner
Copy link

Superseded by #73, I am taking control of this @trinity-1686a to solve conflicts that keep appearing

Superseded by #73, I am taking control of this @trinity-1686a to solve conflicts that keep appearing
lx closed this pull request 2021-05-03 20:18:44 +00:00
trinity-1686a deleted branch clippy 2021-05-05 19:30:34 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No labels
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#58
No description provided.
Delete branch "trinity-1686a:clippy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?