Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

fix typo in peertube doc #617

Merged
lx merged 2 commits from Lapineige/garage:main into main 2024-01-11 11:19:43 +00:00
Conversation 2 Commits 2 Files Changed 1 +2 -2
Lapineige commented 2023-08-19 15:18:23 +00:00
Contributor
Copy Link
No description provided.
Lapineige added 1 commit 2023-08-19 15:18:24 +00:00
continuous-integration/drone/pr Build is passing Details
5ffcdb4634 fix typo
Lapineige added 1 commit 2023-08-19 20:29:25 +00:00
continuous-integration/drone/pr Build is passing Details
47e7f9e122 another typo
Lapineige commented 2023-08-19 20:32:13 +00:00
Author
Contributor
Copy Link

That off-topic on this PR, but I wonder why the instructions in the doc gives you a configuration to use Garage as S3 storage for Peertube… on the same server.
Isn't the whole purpose of an S3 storage to be externalised ? Is this only intended (in this case) to be there as a live backup ?

That off-topic on this PR, but I wonder why the instructions in the doc gives you a configuration to use Garage as S3 storage for Peertube… on the same server. Isn't the whole purpose of an S3 storage to be externalised ? Is this only intended (in this case) to be there as a live backup ?
lx commented 2023-08-28 08:48:48 +00:00
Owner
Copy Link

The endpoint could be "localhost" if you are using a gateway Garage node on the node where PeerTube is running. This is generally a good configuration as it reduces latency of operations and avoids using TLS locally. But the S3 server could also totally be externalised, both configurations are good for different use cases.

The endpoint could be "localhost" if you are using a gateway Garage node on the node where PeerTube is running. This is generally a good configuration as it reduces latency of operations and avoids using TLS locally. But the S3 server could also totally be externalised, both configurations are good for different use cases.
lx reviewed 2023-08-28 08:49:59 +00:00
doc/book/connect/apps/index.md
@ -146,7 +146,7 @@ Keep the Key ID and the Secret key in a pad, they will be needed later.
We need two buckets, one for normal videos (named peertube-video) and one for webtorrent videos (named peertube-playlist).
lx commented 2023-08-28 08:49:59 +00:00
Owner
Copy Link

The name "peertube-video" without an s is still there in the text of line 147. There are also inconsistencies with "peertube-playlist".

The name "peertube-video" without an s is still there in the text of line 147. There are also inconsistencies with "peertube-playlist".
lx reviewed 2023-08-28 08:50:20 +00:00
lx left a comment
Owner
Copy Link

Would you mind fixing the remaining inconsistencies as well?

Would you mind fixing the remaining inconsistencies as well?
lx merged commit d91a1de731 into main 2024-01-11 11:19:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#617
No description provided.
Delete Branch "Lapineige/garage:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?