Add more clients in the test #65

quentin · 2021-04-28T10:15:49Z

quentin commented

2021-04-28 10:15:49 +00:00

Make Minio works
Activate mc and rclone in the CI

Fixes #60 (we are able to do the same set of operation with minio, including delete, than other clients)
Related to #64 (we use a socat TLS proxy to prevent minio from signing payload)

Note: it is possible to only run tests for some clients.
Example, if you want to run tests only for minio:

SKIP_AWS=1 SKIP_S3CMD=1 SKIP_RCLONE=1 ./script/test-smoke.sh

If you do not wish to install socat or minio:

SKIP_HTTPS=1 SKIP_MC=1 ./script/test-smoke.sh

- [x] Make Minio works - [x] Activate `mc` and `rclone` in the CI Fixes #60 (we are able to do the same set of operation with minio, including delete, than other clients) Related to #64 (we use a socat TLS proxy to prevent minio from signing payload) Note: it is possible to only run tests for some clients. Example, if you want to run tests only for minio: ``` SKIP_AWS=1 SKIP_S3CMD=1 SKIP_RCLONE=1 ./script/test-smoke.sh ``` If you do not wish to install socat or minio: ``` SKIP_HTTPS=1 SKIP_MC=1 ./script/test-smoke.sh ```

quentin changed title from ~~[WIP] Add more clients in the test~~ to Add more clients in the test

2021-04-30 20:52:31 +00:00

quentin force-pushed test/more-clients from 513ecf05f1 to 12f85cd36b

2021-04-30 22:46:50 +00:00

Compare

quentin referenced this pull request

2021-05-02 09:58:49 +00:00

Implement ListBuckets #70

lx requested changes 2021-05-02 11:23:19 +00:00

lx left a comment

@quentin should this be merged?

If so, can you cleanup the history by squashing everything into one single commit? (or maybe more but only if it makes sense to keep the intermediary steps, at the moment it looks like a lot of noise)

git rebase -i origin/main

@quentin should this be merged? If so, can you cleanup the history by squashing everything into one single commit? (or maybe more but only if it makes sense to keep the intermediary steps, at the moment it looks like a lot of noise) `git rebase -i origin/main`

script/dev-env-aws.sh Outdated

					
				@ -5,4 +3,0 @@

				GARAGE_DEBUG="${REPO_FOLDER}/target/debug/"

				GARAGE_RELEASE="${REPO_FOLDER}/target/release/"

				PATH="${GARAGE_DEBUG}:${GARAGE_RELEASE}:$PATH"

lx commented

2021-05-02 11:17:22 +00:00

Why is this going away here, but not in dev-env-{mc,rclone,...}.sh ?

Why is this going away here, but not in `dev-env-{mc,rclone,...}.sh` ?

quentin marked this conversation as resolved

quentin added 1 commit 2021-05-02 13:04:10 +00:00

Add minio & rclone to our functional tests

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

ef4d6e782a

It is now possible to configure which clients
you do not want to test with the env variable SKIP_XXX=1,
XXX being the client name. eg. SKIP_S3CMD=1 ./script/test-smoke.sh

quentin commented

2021-05-02 13:05:51 +00:00