convert_db: allow LMDB map size override #691

Merged
lx merged 4 commits from zdenek.crha/garage:convert_db_lmdb_map_size into main 2024-01-24 08:19:45 +00:00

4 commits

Author SHA1 Message Date
0eef8a69f0 make all garage_db::Engine variants un-conditional
All checks were successful
continuous-integration/drone/pr Build is passing
Having all Engine enum variants conditional causes compilation errors
when *none* of the DB engine features is enabled. This is not an issue
for full garage build, but affects crates that use garage_db as
dependency.

Change all variants to be present at all times. It solves compilation
errors and also allows us to better differentiate between invalid DB
engine name and engine with support not compiled in current binary.
2024-01-22 21:12:02 +01:00
74e72fc996 convert_db: cleanup naming and comments for open overrides
All checks were successful
continuous-integration/drone/pr Build is passing
2024-01-22 17:52:39 +01:00
4b54e053df convert_db: prevent conversion between same input/output engine
All checks were successful
continuous-integration/drone/pr Build is passing
Use optional DB open overrides for both input and output database.

Duplicating the same override flag for input/output would result in too
many, too long flags. It would be too costly for very rare edge-case
where converting between same DB engine, just with different flags.

Because overrides flags for different engines are disjoint and we are
preventing conversion between same input/ouput DB engine, we can have
only one set.

The override flag will be passed either to input or output, based on
engine type it belongs to. It will never be passed to both of them and
cause unwelcome surprise to user.
2024-01-18 17:57:56 +01:00
8527dd87cc convert_db: allow LMDB map size override
All checks were successful
continuous-integration/drone/pr Build is passing
2024-01-17 21:20:34 +01:00