Deuxfleurs/garage
38
58
Fork 75
Code Issues 104 Pull requests 16 Releases 30 Wiki Activity

WIP: jepsen.garage nixos test #725

Draft
yuka wants to merge 4 commits from yuka/garage:jepsen-nixos-test into main
pull from: yuka/garage:jepsen-nixos-test
merge into: Deuxfleurs:main
Conversation 2 Commits 4 Files changed 5 +5707 -17
yuka commented 2024-02-19 22:57:24 +00:00
Contributor
Copy link

Run the jepsen tests in a nix derivation as an isolated and reproducible way of setting up the environment.

Motivation: The vagrant setup is already mostly that, but it still requires me to set up virtualbox including kernel modules, and in any case some rootful setup, which kind of bothered me

This is an incomplete proof of concept, because:

  • Only runs one scenario, with one garage version
  • Requires setting the nixpkgs to nixos-unstable which might break other things
  • Needs updates to the documentation for how to run the jepsen tests without nixos after the migration to deps.edn
Run the jepsen tests in a nix derivation as an isolated and reproducible way of setting up the environment. Motivation: The vagrant setup is already mostly that, but it still requires me to set up virtualbox including kernel modules, and in any case some rootful setup, which kind of bothered me This is an incomplete proof of concept, because: - Only runs one scenario, with one garage version - Requires setting the nixpkgs to nixos-unstable which might break other things - Needs updates to the documentation for how to run the jepsen tests without nixos after the migration to deps.edn
yuka force-pushed jepsen-nixos-test from 388136df8f to 351e5ca88b 2024-02-19 22:58:00 +00:00 Compare
yuka force-pushed jepsen-nixos-test from 351e5ca88b to cd0142fbdc 2024-02-19 22:58:19 +00:00 Compare
yuka force-pushed jepsen-nixos-test from cd0142fbdc to 16a26af0fe 2024-02-19 23:02:14 +00:00 Compare
yuka force-pushed jepsen-nixos-test from 16a26af0fe to 4852eb4b6b 2024-02-19 23:05:09 +00:00 Compare
yuka force-pushed jepsen-nixos-test from 4852eb4b6b to fc6c94e811 2024-02-19 23:13:00 +00:00 Compare
lx commented 2024-03-06 11:09:08 +00:00
Owner
Copy link

I think it would be nice to get this merged so that we can run the Jepsen testing pipeline in our CI.

Some remarks:

  • It is not desirable to set nixpkgs to unstable for the build process. Could it be refactored to keep the nixpkgs input to what it was previously, and have a second input, for example called nixpkgs-unstable, that is passed to the part that does Jepsen testing?

  • Could the bulk of the Jepsen testing be moved to an external file like nix/jepsen.nix to avoid crowding the main flake.nix file?

  • Your PR removes the project.clj in the Jepsen script directory. Is this strictly necessary to make it possible to run as a Nix derivation? Does it not prevent running it as before using regular lein commands?

I think it would be nice to get this merged so that we can run the Jepsen testing pipeline in our CI. Some remarks: - It is not desirable to set nixpkgs to unstable for the build process. Could it be refactored to keep the nixpkgs input to what it was previously, and have a second input, for example called `nixpkgs-unstable`, that is passed to the part that does Jepsen testing? - Could the bulk of the Jepsen testing be moved to an external file like `nix/jepsen.nix` to avoid crowding the main flake.nix file? - Your PR removes the `project.clj` in the Jepsen script directory. Is this strictly necessary to make it possible to run as a Nix derivation? Does it not prevent running it as before using regular `lein` commands?
lx commented 2024-03-06 11:25:54 +00:00
Owner
Copy link

(Looks like the CI pipeline is broken, probably because of nixpkgs unstable. It's unable to build Wine which we use to test the winscp client)

(Looks like the CI pipeline is broken, probably because of nixpkgs unstable. It's unable to build Wine which we use to test the winscp client)
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Required
Details
This pull request has changes conflicting with the target branch.
  • flake.lock
  • flake.nix
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u jepsen-nixos-test:yuka-jepsen-nixos-test
git checkout yuka-jepsen-nixos-test
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#725
No description provided.
Delete branch "yuka/garage:jepsen-nixos-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?