Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

Fixes to garage_net peering manager #786

Merged
lx merged 3 commits from net-fixes into next-0.10 2024-03-21 10:26:37 +00:00
Conversation 0 Commits 3 Files Changed 5 +118 -120
lx commented 2024-03-21 09:53:27 +00:00
Owner
Copy Link
  • Exchange peer lists only between nodes that are not connected to the same set of other nodes, don't exchange in the case of connections to the same set of nodes but on possibly different addresses
  • Stop reporting an address for local node or nodes that aren't connected, only report the address of an actual outgoing connection. The local address reported by garage status and in the Admin API will now always be the rpc_public_addr from config (or the autodetected value if it is not specified). Fix #761
  • Fix bad stuff going on when trying to connect to local node
- [x] Exchange peer lists only between nodes that are not connected to the same set of other nodes, don't exchange in the case of connections to the same set of nodes but on possibly different addresses - [x] Stop reporting an address for local node or nodes that aren't connected, only report the address of an actual outgoing connection. The local address reported by `garage status` and in the Admin API will now always be the `rpc_public_addr` from config (or the autodetected value if it is not specified). Fix #761 - [x] Fix bad stuff going on when trying to connect to local node
lx added 3 commits 2024-03-21 09:53:27 +00:00
ci/woodpecker/pr/debug Pipeline was successful Details
ci/woodpecker/push/debug Pipeline was successful Details
3844110cd0
[net-fixes] netapp peer exchange: send only currently connected address
lx merged commit 7e0107c47d into next-0.10 2024-03-21 10:26:37 +00:00
lx deleted branch net-fixes 2024-03-21 10:26:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#786
No description provided.
Delete Branch "net-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?