Deuxfleurs
/
garage
42
39
Fork 55
Code Issues 71 Pull Requests 8 Releases 29 Wiki Activity

WIP: add rpc_public_addr_subnet config option #817

Draft
flokli wants to merge 1 commits from flokli/garage:rpc_public_addr_subnet into main
pull from: flokli/garage:rpc_public_addr_subnet
merge into: Deuxfleurs:main
Conversation 0 Commits 1 Files Changed 8 +57 -9
flokli commented 2024-04-23 09:18:18 +00:00
Contributor
Copy Link

In case rpc_public_addr is not set, but autodiscovery is used, this
allows filtering the list of automatically discovered IPs to a specific
subnet.

For example, if nodes should pick their IP inside a specific subnet,
but you don't want to explicitly write the IP down (as it's dynamic, or
you want to share configs across nodes), you can use this option.

Fixes #811.

In case `rpc_public_addr` is not set, but autodiscovery is used, this allows filtering the list of automatically discovered IPs to a specific subnet. For example, if nodes should pick *their* IP inside a specific subnet, but you don't want to explicitly write the IP down (as it's dynamic, or you want to share configs across nodes), you can use this option. Fixes https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/811.
flokli added 1 commit 2024-04-23 09:18:19 +00:00
ci/woodpecker/pr/debug Pipeline failed Details
79729da4af add rpc_public_addr_subnet config option 
In case `rpc_public_addr` is not set, but autodiscovery is used, this
allows filtering the list of automatically discovered IPs to a specific
subnet.

For example, if nodes should pick *their* IP inside a specific subnet,
but you don't want to explicitly write the IP down (as it's dynamic, or
you want to share configs across nodes), you can use this option.
flokli changed title from add rpc_public_addr_subnet config option to WIP: add rpc_public_addr_subnet config option 2024-04-23 09:18:25 +00:00
flokli reviewed 2024-04-23 09:24:56 +00:00
Cargo.toml Outdated
@ -55,6 +55,7 @@ hexdump = "0.1"
hmac = "0.12"
idna = "0.5"
itertools = "0.12"
ipnet = "2.9.0"
flokli commented 2024-04-23 09:24:56 +00:00
Author
Contributor
Copy Link

This was already in the list of dependencies (through reqwest), but we now explicitly depend on it, too.

This was already in the list of dependencies (through `reqwest`), but we now explicitly depend on it, too.
👍 1
flokli force-pushed rpc_public_addr_subnet from 79729da4af to 3dc836afcb 2024-04-23 09:38:18 +00:00 Compare
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#817
No description provided.
Delete Branch "flokli/garage:rpc_public_addr_subnet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?