Deuxfleurs/garage
48
55
Fork 73
Code Issues 100 Pull requests 15 Releases 30 Wiki Activity

Include old_versions when merging layouts, don't remove old layout versions #854

Closed
dominik wants to merge 3 commits from dominik/garage:historical_layout_fix into main
pull from: dominik/garage:historical_layout_fix
merge into: Deuxfleurs:main
Conversation 1 Commits 3 Files changed 2 +13 -11
dominik commented 2024-08-15 15:49:27 +00:00
First-time contributor
Copy link

I have run into the same problem as described in #841 After investigating, I've realized only active layout versions are used to update the node's layout. If we are joining a new/fresh node, it wouldn't be able to successfully sync its layout with existing nodes.

This is also why I have removed code for removing old layout versions, as potentially they might be needed in the future when adding new nodes.

Would appreciate is there would be a v1.0.1 release fixing this problem.

Disclaimer: I don't know what I'm doing. I've never written or read any Rust code before. I don't know if this change would have some unintended consequences. I have tested it and seems to work fine.

I have run into the same problem as described in https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/841 After investigating, I've realized only active layout versions are used to update the node's layout. If we are joining a new/fresh node, it wouldn't be able to successfully sync its layout with existing nodes. This is also why I have removed code for removing old layout versions, as potentially they might be needed in the future when adding new nodes. Would appreciate is there would be a v1.0.1 release fixing this problem. Disclaimer: I don't know what I'm doing. I've never written or read any Rust code before. I don't know if this change would have some unintended consequences. I have tested it and seems to work fine.
dominik added 1 commit 2024-08-15 15:49:28 +00:00
Include old_versions when merging layouts, don't remove old layout versions
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
f8d0affd82
dominik added 1 commit 2024-08-19 16:37:15 +00:00
Consider both old and current versions when verifying layout history
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
824e473809
dominik added 1 commit 2024-08-19 18:32:39 +00:00
Fix fmt
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
b5cefc0a99
lx commented 2024-08-24 10:17:04 +00:00
Owner
Copy link

Hey, thank you very much for your involvement and for making this PR. Unfortunately, I think this is not the correct way to fix this issue, because we do want the old version list to be bounded. If it were not bounded, this would cause unlimited growth of network traffic when Garage clusters become older and start accumulating historical layouts. I am preparing a patch with hopefully a good solution to this issue.

Hey, thank you very much for your involvement and for making this PR. Unfortunately, I think this is not the correct way to fix this issue, because we do want the old version list to be bounded. If it were not bounded, this would cause unlimited growth of network traffic when Garage clusters become older and start accumulating historical layouts. I am preparing a patch with hopefully a good solution to this issue.
lx closed this pull request 2024-08-24 10:17:05 +00:00
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#854
No description provided.
Delete branch "dominik/garage:historical_layout_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?