Deuxfleurs
/
garage
42
39
Fork 55
Code Issues 71 Pull Requests 6 Releases 29 Wiki Activity

warn when inconsistent level of replication is detected #92

Merged
lx merged 3 commits from trinity-1686a/garage:warn-inconsistent-replication into main 2021-06-02 11:30:40 +00:00
Conversation 3 Commits 3 Files Changed 1 +16
trinity-1686a commented 2021-06-02 10:39:31 +00:00
Owner
Copy Link

fix #88
this is a very verbose warn (appears dozens of time per minute), but as this is warning against a dangerous configuration issue, I don't think it really needs rate-limiting

fix #88 this is a very verbose warn (appears dozens of time per minute), but as this is warning against a dangerous configuration issue, I don't think it really needs rate-limiting
trinity-1686a added 1 commit 2021-06-02 10:39:34 +00:00
continuous-integration/drone/pr Build is passing Details
e6cfb47be2 warn when inconsistent level of replication is detected
lx commented 2021-06-02 10:45:39 +00:00
Owner
Copy Link

Looks nice but I'd go even stronger: as soon as we detect someone has a different replication mode, show an error and exit(1)

Looks nice but I'd go even stronger: as soon as we detect someone has a different replication mode, show an error and exit(1)
👍 1
trinity-1686a commented 2021-06-02 10:49:29 +00:00
Author
Owner
Copy Link

I guess "as soon as we detect someone has a different replication mode" should be interpreted as "someone with higher level of replication", so one node with replication=1 won't bring down the whole cluster?

I guess "as soon as we detect someone has a different replication mode" should be interpreted as "someone with higher level of replication", so one node with replication=1 won't bring down the whole cluster?
lx commented 2021-06-02 10:55:08 +00:00
Owner
Copy Link

Yes ok!

Yes ok!
trinity-1686a added 1 commit 2021-06-02 11:12:42 +00:00
continuous-integration/drone/pr Build is failing Details
13bd3138cb error and exit on replication level mismatch
trinity-1686a added 1 commit 2021-06-02 11:22:14 +00:00
continuous-integration/drone/pr Build is passing Details
8611f8c0ef fix formating
lx merged commit 30a7dee920 into main 2021-06-02 11:30:40 +00:00
trinity-1686a deleted branch warn-inconsistent-replication 2021-06-02 11:58:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#92
No description provided.
Delete Branch "trinity-1686a/garage:warn-inconsistent-replication"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?