compile with crane #950

Merged

lx merged 1 commit from nix-crane into main 2025-02-03 15:54:54 +00:00

Conversation 1 Commits 1 Files changed 16 +281 -7317

lx commented 2025-02-01 22:45:54 +00:00

Owner

Copy link

Replace cargo2nix, which is not seeing regular updates recently, with crane.

This does not separate each Garage crate into a separate Nix derivation. I think recently caching was not working correctly for Garage crates, debug builds were always rebuilding everything. With crane, we always rebuild all garage crates but it is done all at once with cargo build which allows for the best speed as Cargo knows best how to do parallelism.

• Build with Crane in flake.nix
• Cross-compilation
• Use the mold linker for debug builds
• implement tests
• Update default.nix and shell.nix
• Update CI scripts

Replace cargo2nix, which is not seeing regular updates recently, with [crane](https://github.com/ipetkov/crane). This does not separate each Garage crate into a separate Nix derivation. I think recently caching was not working correctly for Garage crates, debug builds were always rebuilding everything. With crane, we always rebuild all garage crates but it is done all at once with cargo build which allows for the best speed as Cargo knows best how to do parallelism. - [x] Build with Crane in `flake.nix` - [x] Cross-compilation - [x] Use the `mold` linker for debug builds - [x] implement tests - [x] Update default.nix and shell.nix - [x] Update CI scripts

lx added 4 commits 2025-02-01 22:45:55 +00:00

wip: build with crane ... 1127239215

- cross compiling doesnt work (c compiler fails)
- default.nix and shell.nix are not updated

cross compilation seems to work e819e1a631

simplify e4e2f48de4

native builds: link with mold acc8d39fd6

maximilien commented 2025-02-02 09:22:08 +00:00

Owner

Copy link

Cannot wait for thissss!

Cannot wait for thissss!

lx added 1 commit 2025-02-02 18:52:53 +00:00

nix: fix tests and reorganize flake outputs 6ee5ab066a

lx force-pushed nix-crane from 6ee5ab066a to 6b727dc6c1 2025-02-02 18:53:59 +00:00 Compare

lx added 3 commits 2025-02-02 19:31:34 +00:00

nix: update default.nix and shell.nix with new crane build bcaced807a

nix build: fix tests incremental building and testing b96db0bc7c

integrate crane cargo tests with woodpecker 5c39144902

lx added 1 commit 2025-02-02 19:33:07 +00:00

fix cargo fmt e7becb3379

lx added 1 commit 2025-02-02 19:34:14 +00:00

woodpecker: remove --no-build-outpu 6294e69c2b

lx added 1 commit 2025-02-02 19:42:08 +00:00

remove git_version in flake, always call it "dev" 55cd2b4051

lx added 1 commit 2025-02-02 19:53:07 +00:00

build release builds with crane in ci 32305cd2db

lx added 1 commit 2025-02-02 20:04:09 +00:00

parallelize tests run (they run in different nix sandboxes) 63074c3cb3

lx force-pushed nix-crane from 63074c3cb3 to 8ab0bb2646 2025-02-02 20:08:57 +00:00 Compare

lx force-pushed nix-crane from 8ab0bb2646 to 05a98ff45c 2025-02-02 20:13:00 +00:00 Compare

lx added 1 commit 2025-02-02 20:18:08 +00:00

get rid of cargo.nix 63aef19bbb

lx added 2 commits 2025-02-02 21:03:06 +00:00

fix cross-compiled builds c4ba50a94a

fix dependency handling for tests 6228f735ef

lx added 1 commit 2025-02-03 09:21:58 +00:00

fix scripts to use result/ instead of result-bin/ 20f8f75823

lx added 1 commit 2025-02-03 09:48:54 +00:00

fix rebuild_index.nix edc40242a4

lx changed title from WIP: compile with crane to compile with crane 2025-02-03 14:37:55 +00:00

lx added 1 commit 2025-02-03 14:55:29 +00:00

nix & ci fixes 4f04550664

lx added 1 commit 2025-02-03 15:01:55 +00:00

rm cargo config.toml and update makefile edc6736502

lx force-pushed nix-crane from edc6736502 to 390a5d97fe 2025-02-03 15:47:32 +00:00 Compare

lx merged commit b9df2d1ad1 into main 2025-02-03 15:54:54 +00:00

lx referenced this pull request from a commit 2025-02-03 15:54:55 +00:00

Merge pull request 'compile with crane' (#950) from nix-crane into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

action

check-aws

The behaviour should be checked against AWS S3

  

action

discussion-needed

We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  

action

for-external-contributors

Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  

action

for-newcomers

An issue that should be newcomer friendly.

  

action

more-info-needed

More information is needed to investigate this issue

  

action

need-funding

This issue represents lots of work, we need to find money to pay our core team work

  

action

triage-required

It's not very clear what we want to do with this issue yet, more thoughts is required

  

kind

correctness

Issues of theoretical correctness that may impact edge-case scenarios

  

kind

ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  

kind

improvement

Feature requests that do not fall in other categories

  

kind

performance

Deceptive performance observed OR idea to improve performances

  

kind

testing

Functional tests, integration tests, Jepsen, etc.

  

kind

usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  

kind

wrong-behavior

Unintended behavior

  

prio

critical

Could impact integrity or availability of production clusters

  

prio

low

For issues that we don't want to spend time on until made absolutely necessary

  

scope

admin-api

Issues concerning the administration API

  

scope

background-healing

Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  

scope

build

Issues with Nix, Drone, Rust Compiler, etc.

  

scope

documentation

  

scope

k8s

Kubernetes related, including Helm Charts

  

scope

layout

Linked to the cluster layout and storage management

  

scope

metadata

Metadata Engine (LMDB, sqlite, etc.)

  

scope

ops

Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  

scope

rpc

Linked to RPC

  

scope

s3-api

Related to the S3 API (especially compatibility issues).

  

scope

security

Cryptography-related, auth-related, authorization-related issues

  

scope

telemetry

OpenTelemetry (traces, metrics, etc.)

No labels

action

check-aws

action

discussion-needed

action

for-external-contributors

action

for-newcomers

action

more-info-needed

action

need-funding

action

triage-required

kind

correctness

kind

ideas

kind

improvement

kind

performance

kind

testing

kind

usability

kind

wrong-behavior

prio

critical

prio

low

scope

admin-api

scope

background-healing

scope

build

scope

documentation

scope

k8s

scope

layout

scope

metadata

scope

ops

scope

rpc

scope

s3-api

scope

security

scope

telemetry

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#950

No description provided.