Deuxfleurs/garage
31
61
Fork 80
Code Issues 91 Pull requests 14 Releases 31 Wiki Activity

implement STREAMING-*-PAYLOAD-TRAILER #960

Merged
lx merged 15 commits from fix-824 into main 2025-02-19 09:59:32 +00:00
Conversation 0 Commits 15 Files changed 36 +1366 -578
lx commented 2025-02-16 17:26:17 +00:00
Owner
Copy link

Fix #824

  • Refactoring to support more values of x-amz-content-sha256
  • Parse streaming payloads with trailer, including unsigned payloads
  • Unify checksum calculation in a new ReqBody type in the garage_api_common::signature module
  • Validate trailing checksums when present
  • Add test for STREAMING-UNSIGNED-PAYLOAD-TRAILER
  • Validate trailing checksum
  • Update aws s3 rust client in our tests
  • remove aws-chunked from content-encoding
  • testing
  • proof-reading
Fix #824 - [x] Refactoring to support more values of x-amz-content-sha256 - [x] Parse streaming payloads with trailer, including unsigned payloads - [x] Unify checksum calculation in a new ReqBody type in the garage_api_common::signature module - [x] Validate trailing checksums when present - [x] Add test for STREAMING-UNSIGNED-PAYLOAD-TRAILER - [x] Validate trailing checksum - [x] Update aws s3 rust client in our tests - [x] remove aws-chunked from content-encoding - [x] testing - [x] proof-reading
lx added 3 commits 2025-02-16 17:26:17 +00:00
api: add logic to parse x-amz-content-sha256
All checks were successful
ci/woodpecker/pr/debug Pipeline was successful
Details
ci/woodpecker/push/debug Pipeline was successful
Details
44a896f9b5
lx added 1 commit 2025-02-16 18:13:09 +00:00
api: streaming: organize code paths to accept unsigned and trailer
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
ci/woodpecker/push/debug Pipeline failed
Details
0289ed06ae
lx force-pushed fix-824 from 0289ed06ae to 7f10bad596 2025-02-16 18:19:44 +00:00 Compare
lx force-pushed fix-824 from 7f10bad596 to a04d6cd5b8 2025-02-17 15:23:59 +00:00 Compare
lx added 2 commits 2025-02-17 18:54:40 +00:00
api: use checksumming in api_common::signature for put/putpart
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
658541d812
lx added 1 commit 2025-02-17 19:11:22 +00:00
api: refactor: move checksumming code around again
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
21c0dda16a
lx added 1 commit 2025-02-18 11:00:53 +00:00
api: streaming signature: fix trailer parsing
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
f8b0817ddc
lx added this to the v1.1 milestone 2025-02-18 11:24:39 +00:00
lx added 1 commit 2025-02-18 11:28:07 +00:00
api: remove content-encoding: aws-chunked for streaming payload
Some checks failed
ci/woodpecker/push/debug Pipeline failed
Details
ci/woodpecker/pr/debug Pipeline failed
Details
15cd326bbd
lx added 2 commits 2025-02-18 11:56:25 +00:00
update aws-sdk-s3 in tests and fix wrong checksumming behavior in GetObject
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
ci/woodpecker/push/debug Pipeline failed
Details
d9128bb5ef
lx added 1 commit 2025-02-18 13:00:08 +00:00
api: validate trailing checksum + add test for unsigned-paylad-trailer
Some checks failed
ci/woodpecker/push/debug Pipeline failed
Details
ci/woodpecker/pr/debug Pipeline failed
Details
604c2f0e05
lx added 1 commit 2025-02-18 13:04:45 +00:00
fix build of crc64fast-nvme
Some checks failed
ci/woodpecker/pr/debug Pipeline failed
Details
ci/woodpecker/push/debug Pipeline failed
Details
fa6608098b
lx force-pushed fix-824 from fa6608098b to 8856acd47b 2025-02-18 13:07:42 +00:00 Compare
lx force-pushed fix-824 from 8856acd47b to e9b308701e 2025-02-18 13:13:28 +00:00 Compare
lx force-pushed fix-824 from e9b308701e to 07c4198a90 2025-02-18 13:51:14 +00:00 Compare
lx force-pushed fix-824 from 07c4198a90 to 9501d91076 2025-02-18 14:10:06 +00:00 Compare
lx force-pushed fix-824 from 9501d91076 to 4576cbc978 2025-02-18 14:12:59 +00:00 Compare
lx force-pushed fix-824 from 4576cbc978 to 9e81ad5ca3 2025-02-18 14:20:06 +00:00 Compare
lx force-pushed fix-824 from 9e81ad5ca3 to 45e10e55f9 2025-02-18 14:33:47 +00:00 Compare
lx added 1 commit 2025-02-18 20:47:58 +00:00
api: various fixes
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
f6e805e7db
lx added 1 commit 2025-02-18 20:56:09 +00:00
api: PutObject: save trailer checksum in metadata
Some checks failed
ci/woodpecker/push/debug Pipeline failed
Details
ci/woodpecker/pr/debug Pipeline failed
Details
b2b371e4c1
lx force-pushed fix-824 from b2b371e4c1 to cfe8e8d45c 2025-02-18 20:56:43 +00:00 Compare
lx added 1 commit 2025-02-18 21:02:26 +00:00
test: verify saved checksums in streaming putobject tests
All checks were successful
ci/woodpecker/push/debug Pipeline was successful
Details
ci/woodpecker/pr/debug Pipeline was successful
Details
6d38907dac
lx changed title from WIP: implement STREAMING-*-PAYLOAD-TRAILER to implement STREAMING-*-PAYLOAD-TRAILER 2025-02-19 09:59:28 +00:00
lx merged commit f64ec6e542 into main 2025-02-19 09:59:32 +00:00
lx deleted branch fix-824 2025-02-19 09:59:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind/experimental

PRs implementing experimental features / features used only for debugging

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind/experimental
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
v1.1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#960
No description provided.
Delete branch "fix-824"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?