trinity-1686a
trinity-1686a commented on pull request Deuxfleurs/garage#192 2022-01-15 12:15:18 +00:00
Handle part_number in HeadObject and GetObject (#191)

I can confirm AWS accept providing the part number list 2, 4, so it neither require starting from 1, nor be sequential, only ordered and between 1 and 10000

trinity-1686a commented on pull request Deuxfleurs/garage#192 2022-01-13 16:23:55 +00:00
Handle part_number in HeadObject and GetObject (#191)

typo

trinity-1686a commented on pull request Deuxfleurs/garage#192 2022-01-13 16:23:55 +00:00
Handle part_number in HeadObject and GetObject (#191)

typo

trinity-1686a commented on pull request Deuxfleurs/garage#192 2022-01-13 16:23:54 +00:00
Handle part_number in HeadObject and GetObject (#191)

to verify, but I think this is stricter than AWS : I believe I've read somewhere it's possible to have holes between part number, so 2, 4, 6 would be a correct sequence. Will try against AWS when I have time

trinity-1686a commented on pull request Deuxfleurs/garage#156 2022-01-12 18:28:18 +00:00
Support STREAMING-AWS4-HMAC-SHA256-PAYLOAD (#64)

this bit has an invalid edge case : by cutting the stream just before a new chunk header, an attacker can truncate the file without it being rejected. Getting here (inner stream returns None and this.buf is empy) is either such a truncation, or a call to SignedPayloadStream::poll_next after it returned Ok(Ready(None)) once, which is a contract error (Ok(Ready(None)) means that the stream has terminated, and poll_next should not be invoked again), so this check and return can be safely removed

trinity-1686a commented on issue Deuxfleurs/garage#190 2022-01-12 10:27:35 +00:00
ETags in returned XML are missing quotes

Actually AWS encode quotes like quick_xml does

Sample response obtained from AWS
<?xml version="1.0" encoding="UTF-8"?>
<ListBucketResult
trinity-1686a created pull request Deuxfleurs/garage#189 2022-01-11 18:17:23 +00:00
WIP: refactor-router
trinity-1686a pushed to refactor-router at trinity-1686a/garage 2022-01-11 18:14:36 +00:00
be4e167c46 refactor s3_router and api_server to make unused Endpoint parameters more obvious
trinity-1686a created branch refactor-router in trinity-1686a/garage 2022-01-11 18:11:50 +00:00
trinity-1686a pushed to refactor-router at trinity-1686a/garage 2022-01-11 18:11:50 +00:00
afb279d916 refactor s3_router and api_server to make unused Endpoint parameters more obvious
17446e3b46 Don't return error document for non-4xx errors
f231cff7e6 Update documentation
001787304c Allow setting index document and error document on the CLI
fcd06e9352 Make use of website config, return error document on error
Compare 10 commits »
trinity-1686a deleted branch compression from trinity-1686a/garage 2021-12-27 09:37:25 +00:00
trinity-1686a deleted branch cleanups from Deuxfleurs/garage 2021-12-27 09:33:54 +00:00
trinity-1686a deleted branch feature/improve-doc from Deuxfleurs/garage 2021-12-27 09:33:50 +00:00
trinity-1686a opened issue Deuxfleurs/garage#179 2021-12-25 11:46:36 +00:00
have some kind of cache for frequently accessed blocks
trinity-1686a commented on issue Deuxfleurs/garage#139 2021-12-25 11:16:43 +00:00
Consider bumping default block size to 10MB

Quick calculation: on a 100Mbit connection, 10MB blocks can be transferred in ~1 second.

Wouldn't that means first byte latency would be normal latency (internal cluster latency + client to…

trinity-1686a pushed to error-anonymous at trinity-1686a/garage 2021-12-18 20:10:50 +00:00
914dd0559c use proper error code for unsupported anonymous s3 access
trinity-1686a created branch error-anonymous in trinity-1686a/garage 2021-12-18 20:10:07 +00:00
trinity-1686a pushed to error-anonymous at trinity-1686a/garage 2021-12-18 20:10:07 +00:00
945b75dbf1 update s3 compatibility list (#177)
ca7b438f3f less strict ListBuckets (#178)
1eb972b1ac Add compression using zstd (#173)
60d4459926 BucketWebsite (#174)
Compare 4 commits »
trinity-1686a commented on pull request Deuxfleurs/garage#172 2021-12-18 17:14:10 +00:00
New model for buckets

would it make sense to be bucket owner without read nor write permission?

trinity-1686a commented on pull request Deuxfleurs/garage#172 2021-12-18 17:14:10 +00:00
New model for buckets

this is a lot of indentation. It may be possible to remove a few layers by using Option::and_then, and doing `param.aliases.items().filter(