improve internal item counter mechanisms and implement bucket quotas #326

Merged

lx merged 23 commits from counters into main 2022-06-15 18:20:31 +00:00

Conversation 1 Commits 23 Files changed 32 +962 -347

lx commented 2022-06-08 08:44:31 +00:00

Owner

Copy link

• Refactoring of internal counting API
• Repair procedure for counters (it's an offline procedure!!!)
• New counter for objects in buckets
• Add quotas to buckets struct
• Add CLI to manage bucket quotas
• Add admin API to manage bucket quotas
• Apply quotas by adding checks on put operations
• Proof-read

- [x] Refactoring of internal counting API - [x] Repair procedure for counters (it's an offline procedure!!!) - [x] New counter for objects in buckets - [x] Add quotas to buckets struct - [x] Add CLI to manage bucket quotas - [x] Add admin API to manage bucket quotas - [x] Apply quotas by adding checks on put operations - [x] Proof-read

lx added 1 commit 2022-06-08 08:44:32 +00:00

Some refactoring of the index counter API 425fe56be8

lx added 3 commits 2022-06-08 15:50:23 +00:00

First implementation of counter repair procedure f8a6fff2b7

Add .clear() on db trees ab374e7178

Call counter tables 'v2' because schema changed since last time 03e811bbbf

lx added 1 commit 2022-06-08 18:03:46 +00:00

First iteration of bucket object counters 17e1111393

lx added 1 commit 2022-06-08 18:16:10 +00:00

Show bucket sizes in garage bucket list 5b38f4cd26

lx added 1 commit 2022-06-09 12:50:36 +00:00

Silence clippy warning 99f6ca4388

lx added 1 commit 2022-06-09 13:06:34 +00:00

Update Cargo.nix ea1022f832

lx added 1 commit 2022-06-09 13:43:42 +00:00

Add quotas to bucket table and show them in CLI c1baa10202

lx added 1 commit 2022-06-09 13:56:37 +00:00

CLI operation bucket set-quotas fe5cf8a530

lx added 1 commit 2022-06-09 14:41:01 +00:00

Quotas are now applied on uploads 1c2e5d9c36

lx added 2 commits 2022-06-10 08:33:04 +00:00

Fix garage_db build on 32-bit systems 138e13071b

Merge branch 'main' into counters c6c4f007f0

lx added 1 commit 2022-06-10 08:52:37 +00:00

New admin API endpoint: UpdateBucket, that unifies website config and quotas ef7db797bd

lx added 1 commit 2022-06-10 09:02:13 +00:00

whoops bad typo here 9695e747e6

lx added 1 commit 2022-06-10 09:03:08 +00:00

reformat a bit 8bbd0db43d

lx added 2 commits 2022-06-10 09:08:33 +00:00

typo in error message 6ae8bbeb13

change k2v-only code e6ce8702d4

lx added 1 commit 2022-06-10 09:13:25 +00:00

Change bucket list command ffe05c3c7d

lx added 1 commit 2022-06-10 09:21:17 +00:00

Change object counter table to use full replication bc29d77ed3

lx added 2 commits 2022-06-10 09:28:09 +00:00

Revert "Change object counter table to use full replication" ... c054de43dd

This reverts commit bc29d77ed3.

Actually distribute counters over nodes 180e7fef0a

lx added 1 commit 2022-06-10 09:30:50 +00:00

Update json in admin api doc 92d912faef

lx added 1 commit 2022-06-10 09:39:24 +00:00

Big whoops 5de641700f

lx changed title from WIP: improve internal item counter mechanisms and implement bucket quotas to improve internal item counter mechanisms and implement bucket quotas 2022-06-10 09:47:00 +00:00

lx commented 2022-06-13 12:09:09 +00:00

Author

Owner

Copy link

Fix #71

Fix #71

lx merged commit 77e3fd6db2 into main 2022-06-15 18:20:31 +00:00

lx referenced this pull request from a commit 2022-06-15 18:20:31 +00:00

improve internal item counter mechanisms and implement bucket quotas (#326)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

action

check-aws

The behaviour should be checked against AWS S3

  

action

discussion-needed

We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  

action

for-external-contributors

Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  

action

for-newcomers

An issue that should be newcomer friendly.

  

action

more-info-needed

More information is needed to investigate this issue

  

action

need-funding

This issue represents lots of work, we need to find money to pay our core team work

  

action

triage-required

It's not very clear what we want to do with this issue yet, more thoughts is required

  

kind

correctness

Issues of theoretical correctness that may impact edge-case scenarios

  

kind

ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  

kind

improvement

Feature requests that do not fall in other categories

  

kind

performance

Deceptive performance observed OR idea to improve performances

  

kind

testing

Functional tests, integration tests, Jepsen, etc.

  

kind

usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  

kind

wrong-behavior

Unintended behavior

  

prio

critical

Could impact integrity or availability of production clusters

  

prio

low

For issues that we don't want to spend time on until made absolutely necessary

  

scope

admin-api

Issues concerning the administration API

  

scope

background-healing

Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  

scope

build

Issues with Nix, Drone, Rust Compiler, etc.

  

scope

documentation

  

scope

k8s

Kubernetes related, including Helm Charts

  

scope

layout

Linked to the cluster layout and storage management

  

scope

metadata

Metadata Engine (LMDB, sqlite, etc.)

  

scope

ops

Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  

scope

rpc

Linked to RPC

  

scope

s3-api

Related to the S3 API (especially compatibility issues).

  

scope

security

Cryptography-related, auth-related, authorization-related issues

  

scope

telemetry

OpenTelemetry (traces, metrics, etc.)

No labels

action

check-aws

action

discussion-needed

action

for-external-contributors

action

for-newcomers

action

more-info-needed

action

need-funding

action

triage-required

kind

correctness

kind

ideas

kind

improvement

kind

performance

kind

testing

kind

usability

kind

wrong-behavior

prio

critical

prio

low

scope

admin-api

scope

background-healing

scope

build

scope

documentation

scope

k8s

scope

layout

scope

metadata

scope

ops

scope

rpc

scope

s3-api

scope

security

scope

telemetry

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#326

No description provided.