Make OTLP exporter optional and allow building without Prometheus exporter (/metrics) #372

Merged

lx merged 3 commits from jirutka/garage:telemetry-and-metrics into improve-deps

2022-09-06 13:11:33 +00:00

Author	SHA1	Message	Date
Jakub Jirutka	ea36b9ff90	Allow building without Prometheus exporter (/metrics endpoint) Some checks failed continuous-integration/drone/pr Build is failing Details prometheus and opentelemetry-prometheus add 7 extra dependencies in total and increases the size of the garage binary by ~7 % (with fat LTO).	2022-09-06 01:15:09 +02:00
Jakub Jirutka	e7af006c1c	Make OTLP exporter optional via feature "telemetry-otlp" opentelemetry-otlp add 48 (!) extra dependencies and increases the size of the garage binary by ~11 % (with fat LTO).	2022-09-06 01:14:47 +02:00
Jakub Jirutka	db72812f01	Use the new cargo feature resolver "2" Garage currently uses the legacy resolver "1". The new one is used by default if the root package specifies 'edition = 2021', which Garage does not (yet). The problem with the legacy resolver is, among others, that features enabled by dev-dependencies are propagated to normal dependencies. This affects e.g. hyper - one of the dev-dependencies enables "http2" feature that adds many extra dependencies. If we build garage without opentelemetry-otlp (this is enabled in the following commit), there's no normal dependency enabling "http2" feature. See https://doc.rust-lang.org/cargo/reference/resolver.html#feature-resolver-version-2	2022-09-06 01:14:19 +02:00

Author

SHA1

Message

Date

Jakub Jirutka

ea36b9ff90

Allow building without Prometheus exporter (/metrics endpoint)

continuous-integration/drone/pr Build is failing

Details

prometheus and opentelemetry-prometheus add 7 extra dependencies in
total and increases the size of the garage binary by ~7 % (with
fat LTO).

2022-09-06 01:15:09 +02:00

Jakub Jirutka

e7af006c1c

Make OTLP exporter optional via feature "telemetry-otlp"

opentelemetry-otlp add 48 (!) extra dependencies and increases the
size of the garage binary by ~11 % (with fat LTO).

2022-09-06 01:14:47 +02:00

Jakub Jirutka

db72812f01

Use the new cargo feature resolver "2"

Garage currently uses the legacy resolver "1". The new one is used
by default if the root package specifies 'edition = 2021', which
Garage does not (yet).

The problem with the legacy resolver is, among others, that features
enabled by dev-dependencies are propagated to normal dependencies.
This affects e.g. hyper - one of the dev-dependencies enables "http2"
feature that adds many extra dependencies. If we build garage without
opentelemetry-otlp (this is enabled in the following commit), there's
no normal dependency enabling "http2" feature.

See https://doc.rust-lang.org/cargo/reference/resolver.html#feature-resolver-version-2

2022-09-06 01:14:19 +02:00