Deuxfleurs/garage
48
55
Fork 73
Code Issues 100 Pull requests 14 Releases 30 Wiki Activity

SSE-C encryption #730

Merged
lx merged 4 commits from sse-c into next-0.10 2024-03-07 15:21:38 +00:00
Conversation 0 Commits 4 Files changed 24 +2090 -271
lx commented 2024-02-23 16:04:47 +00:00
Owner
Copy link
  • Adapt data model
  • Shared functions for handling encryption and decryption
    • tests
  • Hook decryption into GetObject
  • Hook encryption into PutObject
  • Hook encryption into PostObject
  • Hook encryption into CreateMultipartUpload + UploadPart
  • Encryption for CopyObject
  • Encryption for UploadPartCopy
  • Fix etag generation for encrypted objects (it's not the md5)
  • GetObject & PutObject: handle presigned requests
    • Get encryption param headers also from query params if applicable, & check they are signed (see #735)
  • Return x-amz-sse-customer-algorithm and x-amz-sse-customer-key-md5 in response headers
  • Make correct use of stream::encrypt_last / decrypt_last
  • Manual testing
  • Integration testing in garage
  • Testing in smoke test
  • Test with nextcloud + write documentation
  • Proof-reading

Fix #602

- [x] Adapt data model - [x] Shared functions for handling encryption and decryption - [x] tests - [x] Hook decryption into GetObject - [x] Hook encryption into PutObject - [x] Hook encryption into PostObject - [x] Hook encryption into CreateMultipartUpload + UploadPart - [x] Encryption for CopyObject - [x] Encryption for UploadPartCopy - [x] Fix etag generation for encrypted objects (it's not the md5) - ~~GetObject & PutObject: handle presigned requests~~ - ~~Get encryption param headers also from query params if applicable, & check they are signed~~ (see #735) - [x] Return x-amz-sse-customer-algorithm and x-amz-sse-customer-key-md5 in response headers - [x] Make correct use of stream::encrypt_last / decrypt_last - [x] Manual testing - [x] Integration testing in garage - [x] Testing in smoke test - [x] Test with nextcloud + write documentation - [x] Proof-reading Fix #602
lx force-pushed sse-c from 2bf2ca8b40 to a5d3a9a286 2024-02-23 16:28:37 +00:00 Compare
lx force-pushed sse-c from 1fdeebc450 to 513a409b43 2024-02-23 17:51:41 +00:00 Compare
lx force-pushed sse-c from a90499b45f to 009b51b976 2024-02-26 18:04:46 +00:00 Compare
lx force-pushed sse-c from 009b51b976 to 8a57cc5cc0 2024-02-26 18:06:25 +00:00 Compare
lx force-pushed sse-c from 8a57cc5cc0 to 982104e78e 2024-02-26 22:07:59 +00:00 Compare
lx force-pushed sse-c from 982104e78e to 9d14a859d8 2024-02-27 09:15:46 +00:00 Compare
lx force-pushed sse-c from 38d7884413 to 8aec3fa3b2 2024-02-27 09:46:46 +00:00 Compare
lx force-pushed sse-c from 64abdf5916 to 871f7ff75b 2024-02-28 11:41:39 +00:00 Compare
lx force-pushed sse-c from 871f7ff75b to 6bc761df9e 2024-02-28 11:49:42 +00:00 Compare
lx force-pushed sse-c from f682d7e006 to fc92ae5694 2024-02-29 13:23:22 +00:00 Compare
lx force-pushed sse-c from 10b8840aaf to 4ae123bf00 2024-03-05 12:51:07 +00:00 Compare
lx force-pushed sse-c from c2a59b222b to d8c5d2a95c 2024-03-06 16:02:07 +00:00 Compare
lx force-pushed sse-c from 425fe03b2c to bec9cf1477 2024-03-06 18:15:38 +00:00 Compare
lx force-pushed sse-c from 04a4afe283 to d32f1e36e1 2024-03-06 18:25:57 +00:00 Compare
lx force-pushed sse-c from d32f1e36e1 to 96b30bfe62 2024-03-06 18:33:58 +00:00 Compare
lx force-pushed sse-c from 96b30bfe62 to 6c2ea89221 2024-03-07 11:07:18 +00:00 Compare
lx force-pushed sse-c from 6c2ea89221 to 81c27e452f 2024-03-07 11:23:41 +00:00 Compare
lx force-pushed sse-c from 661c7ab0b2 to c0454e6c3a 2024-03-07 13:02:09 +00:00 Compare
lx force-pushed sse-c from c0454e6c3a to ad82f5b48a 2024-03-07 13:10:42 +00:00 Compare
lx force-pushed sse-c from ad82f5b48a to ed2bc3acb9 2024-03-07 13:43:54 +00:00 Compare
lx force-pushed sse-c from 2cfddbaeb4 to 3fcb54e3cf 2024-03-07 14:43:56 +00:00 Compare
lx changed title from WIP: SSE-C encryption to SSE-C encryption 2024-03-07 15:21:24 +00:00
lx merged commit 2fd13c7d13 into next-0.10 2024-03-07 15:21:38 +00:00
lx deleted branch sse-c 2024-03-07 15:21:39 +00:00
lx added this to the v1.0 milestone 2024-03-07 15:22:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
v1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#730
No description provided.
Delete branch "sse-c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?