Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

SSE-C encryption #730

Merged
lx merged 4 commits from sse-c into next-0.10 2024-03-07 15:21:38 +00:00
Conversation 0 Commits 4 Files Changed 24 +2090 -271
lx commented 2024-02-23 16:04:47 +00:00
Owner
Copy Link
  • Adapt data model
  • Shared functions for handling encryption and decryption
    • tests
  • Hook decryption into GetObject
  • Hook encryption into PutObject
  • Hook encryption into PostObject
  • Hook encryption into CreateMultipartUpload + UploadPart
  • Encryption for CopyObject
  • Encryption for UploadPartCopy
  • Fix etag generation for encrypted objects (it's not the md5)
  • GetObject & PutObject: handle presigned requests
    • Get encryption param headers also from query params if applicable, & check they are signed (see #735)
  • Return x-amz-sse-customer-algorithm and x-amz-sse-customer-key-md5 in response headers
  • Make correct use of stream::encrypt_last / decrypt_last
  • Manual testing
  • Integration testing in garage
  • Testing in smoke test
  • Test with nextcloud + write documentation
  • Proof-reading

Fix #602

- [x] Adapt data model - [x] Shared functions for handling encryption and decryption - [x] tests - [x] Hook decryption into GetObject - [x] Hook encryption into PutObject - [x] Hook encryption into PostObject - [x] Hook encryption into CreateMultipartUpload + UploadPart - [x] Encryption for CopyObject - [x] Encryption for UploadPartCopy - [x] Fix etag generation for encrypted objects (it's not the md5) - ~~GetObject & PutObject: handle presigned requests~~ - ~~Get encryption param headers also from query params if applicable, & check they are signed~~ (see #735) - [x] Return x-amz-sse-customer-algorithm and x-amz-sse-customer-key-md5 in response headers - [x] Make correct use of stream::encrypt_last / decrypt_last - [x] Manual testing - [x] Integration testing in garage - [x] Testing in smoke test - [x] Test with nextcloud + write documentation - [x] Proof-reading Fix #602
lx force-pushed sse-c from 2bf2ca8b40 to a5d3a9a286 2024-02-23 16:28:37 +00:00 Compare
lx force-pushed sse-c from 1fdeebc450 to 513a409b43 2024-02-23 17:51:41 +00:00 Compare
lx force-pushed sse-c from a90499b45f to 009b51b976 2024-02-26 18:04:46 +00:00 Compare
lx force-pushed sse-c from 009b51b976 to 8a57cc5cc0 2024-02-26 18:06:25 +00:00 Compare
lx force-pushed sse-c from 8a57cc5cc0 to 982104e78e 2024-02-26 22:07:59 +00:00 Compare
lx force-pushed sse-c from 982104e78e to 9d14a859d8 2024-02-27 09:15:46 +00:00 Compare
lx force-pushed sse-c from 38d7884413 to 8aec3fa3b2 2024-02-27 09:46:46 +00:00 Compare
lx force-pushed sse-c from 64abdf5916 to 871f7ff75b 2024-02-28 11:41:39 +00:00 Compare
lx force-pushed sse-c from 871f7ff75b to 6bc761df9e 2024-02-28 11:49:42 +00:00 Compare
lx force-pushed sse-c from f682d7e006 to fc92ae5694 2024-02-29 13:23:22 +00:00 Compare
lx force-pushed sse-c from 10b8840aaf to 4ae123bf00 2024-03-05 12:51:07 +00:00 Compare
lx force-pushed sse-c from c2a59b222b to d8c5d2a95c 2024-03-06 16:02:07 +00:00 Compare
lx force-pushed sse-c from 425fe03b2c to bec9cf1477 2024-03-06 18:15:38 +00:00 Compare
lx force-pushed sse-c from 04a4afe283 to d32f1e36e1 2024-03-06 18:25:57 +00:00 Compare
lx force-pushed sse-c from d32f1e36e1 to 96b30bfe62 2024-03-06 18:33:58 +00:00 Compare
lx force-pushed sse-c from 96b30bfe62 to 6c2ea89221 2024-03-07 11:07:18 +00:00 Compare
lx force-pushed sse-c from 6c2ea89221 to 81c27e452f 2024-03-07 11:23:41 +00:00 Compare
lx force-pushed sse-c from 661c7ab0b2 to c0454e6c3a 2024-03-07 13:02:09 +00:00 Compare
lx force-pushed sse-c from c0454e6c3a to ad82f5b48a 2024-03-07 13:10:42 +00:00 Compare
lx force-pushed sse-c from ad82f5b48a to ed2bc3acb9 2024-03-07 13:43:54 +00:00 Compare
lx force-pushed sse-c from 2cfddbaeb4 to 3fcb54e3cf 2024-03-07 14:43:56 +00:00 Compare
lx changed title from WIP: SSE-C encryption to SSE-C encryption 2024-03-07 15:21:24 +00:00
lx merged commit 2fd13c7d13 into next-0.10 2024-03-07 15:21:38 +00:00
lx deleted branch sse-c 2024-03-07 15:21:39 +00:00
lx added this to the v1.0 milestone 2024-03-07 15:22:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
v1.0
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#730
No description provided.
Delete Branch "sse-c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?