Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

Split presigned signature verification + fix conditions #735

Merged
lx merged 6 commits from fix-presigned into main 2024-02-28 11:38:01 +00:00
Conversation 0 Commits 6 Files Changed 8 +501 -286
lx commented 2024-02-27 17:41:59 +00:00
Owner
Copy Link

The objective of this PR is to split code paths for regular signature verification, and verification of pre-signed URLs. The idea behind this is that we want a clearer view of what is verified upon signature verification, because it isn't exactly the same thing for both (we have to check with the official docs). Also we want to check that the correct set of headers is signed, I don't think we do it now but Amazon says that all x-amz-* headers must be included in the signedheaders list if they are to be used.

The objective of this PR is to split code paths for regular signature verification, and verification of pre-signed URLs. The idea behind this is that we want a clearer view of what is verified upon signature verification, because it isn't exactly the same thing for both (we have to check with the official docs). Also we want to check that the correct set of headers is signed, I don't think we do it now but Amazon says that all x-amz-* headers must be included in the signedheaders list if they are to be used.
lx changed title from [fix-presigned] WIP: try to split presigned/normal signature verification to WIP: split presigned signature verification + fix checks 2024-02-27 22:02:20 +00:00
lx changed title from WIP: split presigned signature verification + fix checks to WIP: split presigned signature verification + fix conditions 2024-02-27 22:02:30 +00:00
lx changed title from WIP: split presigned signature verification + fix conditions to Split presigned signature verification + fix conditions 2024-02-28 10:44:03 +00:00
lx force-pushed fix-presigned from e610e16abb to 90cab5b8f2 2024-02-28 11:24:38 +00:00 Compare
lx merged commit 10031a3a91 into main 2024-02-28 11:38:01 +00:00
lx deleted branch fix-presigned 2024-02-28 11:38:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#735
No description provided.
Delete Branch "fix-presigned"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?