use netapp streaming body #343
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#343
Loading…
Reference in New Issue
No description provided.
Delete Branch "netapp-stream-body"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
TODO:
433cbd65d1
to6a78c0715c
d888c9c193
tofe5dadb756
9c1889c630
tof728893dae
f728893dae
to326d418367
Currently stalled as there is an issue I'm unable to fix.
test-smoke.sh
pretty consistently reproduces the issue: transfers (GetObject requests) get stuck in the middle. I don't understand exactly what is going on, but it looks like entire netapp connections are blocked as pings start timing out, it's not just an issue with a stream that ends prematurely.Lines 188 and 229 in
block/manager.rs
need to be commented for the bug to happen: when these lines are commented, nodes won't priorize reading block from local storage and will instead ask remote nodes most of the time. This is the condition under which the issue happens. (when request priorization is enabled, nodes in test-smoke will always read locally so the bug doesn't happen).I don't want to spend too much time on this, merging this is not a high priority.
Next steps: ??? Maybe try to reproduce the issue with a simpler netapp program, and not an entire Garage (here there are too many connections open at once and we can't really see what is happening)
a1c224e2e8
toe935861854
WIP: use netapp streaming bodyto use netapp streaming body