use netapp streaming body #343

Merged
lx merged 31 commits from netapp-stream-body into main 3 months ago
lx commented 5 months ago
Owner

TODO:

  • Test OrderTag works (check trace-level logs in integration test)
  • Publish netapp 0.5.0 and use that as a dependency (revert change to .nix to pull from git repo)
  • In get with range, use streaming also (use StreamExt::scan for slicing)
TODO: - [x] Test OrderTag works (check trace-level logs in integration test) - [x] Publish netapp 0.5.0 and use that as a dependency (revert change to .nix to pull from git repo) - [x] In get with range, use streaming also (use StreamExt::scan for slicing)
lx added 1 commit 5 months ago
433cbd65d1
First adaptation to WIP netapp with streaming body
lx force-pushed netapp-stream-body from 433cbd65d1 to 6a78c0715c 5 months ago
lx changed target branch from main to lx-perf-improvements 5 months ago
lx added 1 commit 5 months ago
d888c9c193
Use streaming in block manager
lx force-pushed netapp-stream-body from d888c9c193 to fe5dadb756 5 months ago
lx added 1 commit 5 months ago
e1d603053f
Fix clippy
lx added 1 commit 5 months ago
4d3f630578
Update cargo.nix
lx added 1 commit 4 months ago
81679f1a7a
update netapp
lx added 1 commit 4 months ago
9c1889c630
Update cargo.nix
lx force-pushed netapp-stream-body from 9c1889c630 to f728893dae 4 months ago
lx force-pushed netapp-stream-body from f728893dae to 326d418367 4 months ago
lx added 1 commit 4 months ago
a1c224e2e8
Factor out node request order selection logic & use in manager
Poster
Owner

Currently stalled as there is an issue I'm unable to fix. test-smoke.sh pretty consistently reproduces the issue: transfers (GetObject requests) get stuck in the middle. I don't understand exactly what is going on, but it looks like entire netapp connections are blocked as pings start timing out, it's not just an issue with a stream that ends prematurely.

Lines 188 and 229 in block/manager.rs need to be commented for the bug to happen: when these lines are commented, nodes won't priorize reading block from local storage and will instead ask remote nodes most of the time. This is the condition under which the issue happens. (when request priorization is enabled, nodes in test-smoke will always read locally so the bug doesn't happen).

I don't want to spend too much time on this, merging this is not a high priority.

Next steps: ??? Maybe try to reproduce the issue with a simpler netapp program, and not an entire Garage (here there are too many connections open at once and we can't really see what is happening)

Currently stalled as there is an issue I'm unable to fix. `test-smoke.sh` pretty consistently reproduces the issue: transfers (GetObject requests) get stuck in the middle. I don't understand exactly what is going on, but it looks like entire netapp connections are blocked as pings start timing out, it's not just an issue with a stream that ends prematurely. Lines 188 and 229 in `block/manager.rs` need to be commented for the bug to happen: when these lines are commented, nodes won't priorize reading block from local storage and will instead ask remote nodes most of the time. This is the condition under which the issue happens. (when request priorization is enabled, nodes in test-smoke will always read locally so the bug doesn't happen). I don't want to spend too much time on this, merging this is not a high priority. Next steps: ??? Maybe try to reproduce the issue with a simpler netapp program, and not an entire Garage (here there are too many connections open at once and we can't really see what is happening)
lx force-pushed netapp-stream-body from a1c224e2e8 to e935861854 4 months ago
lx added 5 commits 3 months ago
8cd02639dc
drone: set TARGET env as needed by "to_s3" func
2c7bae935a
Configure structopt to report the right version
532eca7ff9
Add some documentation for Caddy
ebc20a8798
Merge branch 'main' into lx-perf-improvements
1921f4f7e6
Merge branch 'lx-perf-improvements' into netapp-stream-body
lx added 2 commits 3 months ago
4da67b0035
Update drone signature
52749e28f7
Merge branch 'lx-perf-improvements' into netapp-stream-body
lx added 1 commit 3 months ago
5d065b8a0f
cargo2nix fix to fetchCrateGit
lx added 1 commit 3 months ago
322dafc761
Try to fix clippy
lx added 5 commits 3 months ago
dd5304f6fc
Replace logging crate pretty_env_logger by tracing_subscriber::fmt
44cd98d2e4
Tracing-subscriber: write to stderr
efbca67ce4
Add env filter to tracing subscriber
eb97e13a6a
update cargo.nix
c9bc9d89de
Merge branch 'lx-perf-improvements' into netapp-stream-body
lx added 1 commit 3 months ago
e598231ca4
update netapp git commit
lx added 1 commit 3 months ago
70231d68b2
Fix bytes_read counter
lx added 1 commit 3 months ago
4b726b0941
netapp recv with unbounded channel removes deadlock
lx added 1 commit 3 months ago
bc977f9a7a
Update to Netapp with OrderTag support and exploit OrderTags
lx added 1 commit 3 months ago
f3bf34b6a1
update netapp: straming + fix-ping
lx added 2 commits 3 months ago
e648bf7b69
update cargo.nix
lx added 1 commit 3 months ago
99b532b85b
Apply PRIO_SECONDARY to block data transfers
lx added 1 commit 3 months ago
1ef87ac4cb
cargo fmt
lx added 1 commit 3 months ago
13b5f28c7e
Make use of BytesBuf from new Netapp
lx added 1 commit 3 months ago
c2cc08852b
Reenable node ordering
lx added 1 commit 3 months ago
4024822585
Update netapp to lastest git version with LAS scheduling
lx added 12 commits 3 months ago
6226f5ceca
Update to netapp 0.4.5 - fixed ping
943d76c583
Ability to dynamically set resync tranquility
5e8baa433d
Make BlockManagerLocked fully private again
5d4b937a00
Ability to have up to 4 concurrently working resync workers
e1751c8a9c
fix clippy
0009fd136c Merge pull request 'Make block resync speed dynamically configurable' (#369) from resync-ajustable-speed into main
07e6bcde85
Merge branch 'main' into lx-perf-improvements
fd8074ad9b
Update .drone.yml signature
d23b3a14fc
Merge branch 'main' into lx-perf-improvements
6b958979bd
Merge branch 'lx-perf-improvements' into netapp-stream-body
lx added 1 commit 3 months ago
907054775d
Faster copy, better get error message
lx added 31 commits 3 months ago
a6e40b75ea Add feature "system-libs" to enable linking against system libraries
7511ba5530 Allow linking against system-provided libsqlite
729a910e14
Remove Heed default features
db72812f01 Use the new cargo feature resolver "2"
e7af006c1c Make OTLP exporter optional via feature "telemetry-otlp"
ea36b9ff90 Allow building without Prometheus exporter (/metrics endpoint)
ed7796924b Merge pull request 'Make OTLP exporter optional and allow building without Prometheus exporter (/metrics)' (#372) from jirutka/garage:telemetry-and-metrics into improve-deps
8d77a76df1
Update .nix files
7de53a4d66
Force disable pkg-config for libsodum-sys and libzstd-sys
48ffaaadfc
Bump versions to 0.8.0 (compatibility is broken already)
bbb970965c
Document available build features
2c2b93acdf
Update Nix files with optional db engines
431dee050f
Remove opentelemetry-otlp dep in api/
1e92e9f782
Disable k2v tests when feature is disabled
0f5689c169
Include code from v0.5.1 directly to remove dependencies
6f02c36a89
cargo fmt
db61f41030
Move GIT_VERSION injection later in build chain to reduce build times
28d86e7602
Report build features in garage --help
2559f63e9b
Make all HTTP services optionnal
2e00809af5
Error messages when system-libs XOR bundled-libs != 1
1449204439
Add warnings when features are not included in build
107853334b
Fix build error
06df301de5
Fix merge
f310fce34b
Inject GIT_VERSION even later
ceb1f0229a
Move version back into util
03c40a0b24 Merge pull request 'Reorganize dependencies' (#373) from improve-deps into main
d9d199a6c9
Merge branch 'main' into lx-perf-improvements
7f54706b95
Merge branch 'lx-perf-improvements' into netapp-stream-body
lx changed target branch from lx-perf-improvements to main 3 months ago
lx added 1 commit 3 months ago
b823151a0b
improvements in block manager
lx added 1 commit 3 months ago
28a4af73ca
Use netapp 0.5 published from crates.io
lx changed title from WIP: use netapp streaming body to use netapp streaming body 3 months ago
lx added 1 commit 3 months ago
ff30891999
Use streaming block API for get with Range requests
lx merged commit 11bdc971e2 into main 3 months ago
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
The pull request has been merged as 11bdc971e2.
Sign in to join this conversation.
Loading…
There is no content yet.