asonix
0 followers · 0 following
Repositories
1
 Projects Packages Public activity Starred repositories
asonix commented on pull request Deuxfleurs/garage#753 2024-03-03 22:28:19 +00:00
Lowercase query parameter keys when parsing

I've deployed this on my network and it seems to be working

asonix pushed to main at asonix/garage 2024-03-03 22:27:04 +00:00
4990460808 Store original-cased query keys alongside query values
asonix commented on pull request Deuxfleurs/garage#753 2024-03-03 21:59:04 +00:00
Lowercase query parameter keys when parsing

garage 0.9.1's canonical request:

HEAD
/pict-rs/
X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=[redacted]&X-Amz-Date=20240303T215113Z&X-Amz-Expires=15&X-Amz-SignedHeaders=host
host:gar…
asonix commented on pull request Deuxfleurs/garage#753 2024-03-03 21:57:41 +00:00
Lowercase query parameter keys when parsing

it seems the canonical_request has lowercased keys, which ends up generating a different signing string than the client which has title-cased keys

asonix commented on pull request Deuxfleurs/garage#753 2024-03-03 21:36:54 +00:00
Lowercase query parameter keys when parsing

Just this isn't enough. Getting the following now:

2024-03-03T21:28:18.033798Z  INFO garage_api::generic_server: [::ffff:10.42.7.110]:41580 HEAD /pict-rs/?X-Amz-Algorithm=AWS4-HMAC-SHA256&X…
asonix created pull request Deuxfleurs/garage#753 2024-03-03 20:36:33 +00:00
Lowercase query parameter keys when parsing
asonix pushed to main at asonix/garage 2024-03-03 20:35:26 +00:00
6a57827da9 Lowercase query parameter keys when parsing
asonix pushed to main at asonix/garage 2024-03-03 20:30:47 +00:00
c4de471de1 Merge pull request 'doc: fix typo in connect/backup.md' (#749) from Armael/garage:doc-typo into main
16e17375c5 doc: fix typo in connect/backup.md
95ab36aae7 Merge pull request 'Bump version to v0.9.2' (#747) from rel-0.9.2 into main
6a7623e90d [rel-0.9.2] Bump version to v0.9.2
70b9904e91 Merge pull request 'AWS signatures v4: don't actually check Content-Type is signed' (#745) from fix-signed-headers into main
Compare 226 commits »
asonix commented on issue Deuxfleurs/garage#752 2024-03-03 20:26:52 +00:00
pict-rs broken after upgrading from 0.9.0 to 0.9.2

Seems like the issue might be a missing to_lowercase in src/api/signature/payload.rs on line 199

looking through Deuxfleurs/garage#735 it seems that the old…

asonix commented on issue Deuxfleurs/garage#752 2024-03-03 19:50:42 +00:00
pict-rs broken after upgrading from 0.9.0 to 0.9.2

0.9.1 seems fine, issue was introduced in 0.9.2

asonix commented on issue Deuxfleurs/garage#752 2024-03-03 19:46:14 +00:00
pict-rs broken after upgrading from 0.9.0 to 0.9.2

I'm trying out 0.9.1 now

asonix opened issue Deuxfleurs/garage#752 2024-03-03 19:43:50 +00:00
pict-rs broken after upgrading from 0.9.0 to 0.9.2
asonix created pull request Deuxfleurs/garage#670 2023-11-21 23:40:51 +00:00
Allow 0 as a part number marker
asonix pushed to main at asonix/garage 2023-11-21 23:40:06 +00:00
92fd899fb6 Allow 0 as a part number marker
asonix created repository asonix/garage 2023-11-21 23:38:36 +00:00
asonix opened issue Deuxfleurs/garage#669 2023-11-21 23:38:31 +00:00
Incompatibility with Nextcloud
asonix commented on issue Deuxfleurs/garage#442 2022-12-14 23:39:46 +00:00
Incompatibility with rusty-s3

Just took a look. Works great!

asonix commented on issue Deuxfleurs/garage#442 2022-12-14 16:18:06 +00:00
Incompatibility with rusty-s3

I'll get this tested later today, thanks!

asonix opened issue Deuxfleurs/garage#442 2022-12-08 15:54:29 +00:00
Incompatibility with rusty-s3